Skip to content

[WIP][SYCL][LevelZero] Force reset of memcpy command-list #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

smaslov-intel
Copy link
Contributor

Signed-off-by: Sergey V Maslov [email protected]

Signed-off-by: Sergey V Maslov <[email protected]>
Copy link
Contributor

@kbsmith-intel kbsmith-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that spelling in comment, LGTM

Signed-off-by: Sergey V Maslov <[email protected]>
Copy link
Contributor

@kbsmith-intel kbsmith-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kbsmith-intel kbsmith-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvchupin
Copy link
Contributor

@smaslov-intel, are the fails related to the change?

@bader bader changed the title Force reset of memcpy command-list [SYCL][LevelZero] Force reset of memcpy command-list Jun 21, 2021
@smaslov-intel
Copy link
Contributor Author

@kbsmith-intel, @pvchupin : I was able to reproduce the hang in https://github.com/intel/llvm-test-suite/blob/intel/SYCL/InorderQueue/in_order_usm_explicit.cpp. There are 3 memcpy submitted into the in-order queue there (all in there own command-lists) and synchronizing the last memcpy's event never finishes. Nothing jumped out at me by just looking at traces, needs debugging.

I consider this being of low priority (and may be even drop it altogether) since a L0 driver complete fix is ready.

@pvchupin
Copy link
Contributor

If that was a workaround and real fix is ready feel free to abandon the change, unless @kbsmith-intel see any value I'm missing...

@smaslov-intel smaslov-intel changed the title [SYCL][LevelZero] Force reset of memcpy command-list [WIP][SYCL][LevelZero] Force reset of memcpy command-list Jun 24, 2021
@smaslov-intel smaslov-intel marked this pull request as draft June 24, 2021 02:00
@smaslov-intel
Copy link
Contributor Author

merged in #4001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants